Fix #23 docker-machine restart fails with CentOS VM #24
Conversation
|
Checking it out ... |
hferentschik
changed the title
There was a problem hiding this comment.
Works like a charm and also addresses #20 :-) Let's get this in asap. I'd like to see some more commentary though around why we do it. Either in the script itself or we start some sort of technical discussions section in the readme where we expand on this and potentially other things we did/do.
| @@ -99,6 +100,41 @@ yum remove -y redhat-logos linux-firmware | |||
| # Clear yum package and metadata cache | |||
| yum clean all | |||
|
|
|||
| # Place holder for base64 encrypt handle-user-data script | |||
There was a problem hiding this comment.
Can you add some comments here to why we do this and how default boot2docker works in comparison which makes it necessary that we do this. Also mentioning that in the case of a 'docker-machine create' this part is basically executed twice. Once as part of the init script here and once by the Red Hat provisioner.
| ${cert_gen} | ||
| EOF | ||
|
|
||
| base64 -d < cert-gen.sh.base64 > cert-gen.sh |
There was a problem hiding this comment.
Technically I think line 104 to 108 are really repetitive and can be automated. One would just write '+${cert_gen}' and one inserts the full monty - cat command, base 63 decode and all.
It would be something like:
${cert_gen}
chmod +x cert-gen.sh
mv cert-gen.sh /opt
where the variable would expand to something like
cat > cert-gen.sh.base64 << EOF
<base 64 encoded script>
EOF
base64 -d < cert-gen.sh.base64 > cert-gen.sh
I think this would be even nicer than what we have. Maybe another issue!?
| @@ -0,0 +1,82 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Can we align the naming of scripts? Either with or without .sh at the end. Personally I can go with both with a slight preference for with .sh. Either way it would be nice to be consistent.
|
Fix for issue #23. |
Restart will now works for machine.