first test at passing image for the image build template #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emterry
changed the title
julialawrence
previously requested changes
Feb 28, 2024
There was a problem hiding this comment.
This is a good first go!
Can you have a look a this example:
https://github.com/ministryofjustice/analytical-platform-visual-studio-code/blob/main/.github/workflows/release.yml
And our style guide
https://technical-documentation.data-platform.service.justice.gov.uk/documentation/platform/infrastructure/github-actions.html#github-actions
It's ok if we don't get the content right the first time, but this is a template and therefore it's important we get the style right and that what we're creating adheres to our style guide.
Please amend to adhere to the guide linked above,
Emterry
force-pushed
the
test-image-push
branch
from
e7e1675 to
b762f5c
Compare
jacobwoffenden
requested changes
Mar 5, 2024
jacobwoffenden
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is an initial first test at pushing an image to the github image repository.
-Creates an initial workflow to push an image