[ESWE-1181] Employer Creation; MN API client, registrar; revise tests #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- implemented `MNJobBoardApiClient`, with integration tests - implemented `EmployerRegistrar` - rename test objects' file to `EmployerObjects` - `EmployerService` is incomplete - revise tests of JobsBoardApiClient
rickchoijd
commented
Jan 23, 2025
| @@ -33,6 +33,7 @@ generic-service: | |||
| EXAMPLE_API_CLIENT_SECRET: "TEMPLATE_KOTLIN_API_CLIENT_SECRET" | |||
| API_CLIENT_ID: "SYSTEM_CLIENT_ID" | |||
| API_CLIENT_SECRET: "SYSTEM_CLIENT_SECRET" | |||
| MN_JOBBOARD_API_TOKEN: "MN_JOBBOARD_API_TOKEN" | |||
There was a problem hiding this comment.
map secret value to env var, for MN APi client's authorisation
| @@ -14,6 +14,7 @@ generic-service: | |||
| # TODO: This should be replaced by a call to a different service, or removed | |||
| EXAMPLE_API_URL: "https://jobs-board-integration-api-preprod.hmpps.service.justice.gov.uk" | |||
| API_BASE_URL_JOBSBOARD: "https://jobs-board-api-preprod.hmpps.service.justice.gov.uk" | |||
| API_BASE_URL_MNJOBBOARD: "https://preprodservices.sequation.net/sequation-job-api" # URL to be confirmed | |||
There was a problem hiding this comment.
Actual URL is TBD
| @@ -11,6 +11,7 @@ generic-service: | |||
| # TODO: This should be replaced by a call to a different service, or removed | |||
| EXAMPLE_API_URL: "https://jobs-board-integration-api.hmpps.service.justice.gov.uk" | |||
| API_BASE_URL_JOBSBOARD: "https://jobs-board-api.hmpps.service.justice.gov.uk" | |||
| API_BASE_URL_MNJOBBOARD: "https://liveservices.sequation.net/sequation-job-api" # URL to be confirmed | |||
There was a problem hiding this comment.
Actual URL is TBD
Comment on lines
+25
to
+34
| fun convert(employer: Employer) = employer.run { | ||
| MNEmployer( | ||
| employerName = name, | ||
| employerBio = description, | ||
| // FIXME translate from employer.sector | ||
| sectorId = 1, | ||
| // FIXME translate from employer.status | ||
| partnerId = 1, | ||
| ) | ||
| } |
There was a problem hiding this comment.
This is incomplete.
ID mapping will be implemented next.
| object EmployerMother { | ||
| object EmployerObjects { |
There was a problem hiding this comment.
Renaming test objects' holder as per previous comments
gbmojo
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MNJobBoardApiClient, with integration testsEmployerRegistrarEmployerObjectsEmployerServiceis incomplete