PI-2715 Handle null actionDesc in OASys assessment summary (#4522)

ministryofjustice · Dec 31, 2024 · 32240ff · 32240ff
1 parent dfa5dd2
commit 32240ff
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/...-and-delius/src/main/kotlin/uk/gov/justice/digital/hmpps/integrations/oasys/OrdsClient.kt b/...-and-delius/src/main/kotlin/uk/gov/justice/digital/hmpps/integrations/oasys/OrdsClient.kt
@@ -141,7 +141,7 @@ data class Need(
 )
 
 data class Action(
-    val actionDesc: String,
+    val actionDesc: String?,
     val actionComment: String?
 )
 

diff --git a/...mary-and-delius/src/main/kotlin/uk/gov/justice/digital/hmpps/service/AssessmentService.kt b/...mary-and-delius/src/main/kotlin/uk/gov/justice/digital/hmpps/service/AssessmentService.kt
@@ -112,9 +112,11 @@ fun Objective.plan(
     )
     criminogenicNeeds.forEachIndexed { index, need -> sp.withNeed(index.deliusIndex(), need.criminogenicNeedDesc) }
     actions?.forEachIndexed { index, action ->
-        sp.withWorkSummary(index.deliusIndex(), action.actionDesc)
-        action.actionComment?.also {
-            sp.withText(index.deliusIndex(), it)
+        if (action.actionDesc != null) {
+            sp.withWorkSummary(index.deliusIndex(), action.actionDesc)
+            action.actionComment?.also {
+                sp.withText(index.deliusIndex(), it)
+            }
         }
     }
     return sp