Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform developers about non-working "rightClick" on Selenium Server 3.x #407

Merged
merged 9 commits into from
Jan 18, 2025

Conversation

aik099
Copy link
Member

@aik099 aik099 commented Jan 11, 2025

Closes #381

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.21%. Comparing base (bedccba) to head (3145d7e).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/Selenium2Driver.php 93.75% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #407      +/-   ##
============================================
+ Coverage     85.45%   86.21%   +0.75%     
- Complexity      182      185       +3     
============================================
  Files             1        1              
  Lines           502      515      +13     
============================================
+ Hits            429      444      +15     
+ Misses           73       71       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aik099 aik099 force-pushed the right-click-exception branch from 9856916 to 4bfeba1 Compare January 11, 2025 13:51
@aik099 aik099 requested a review from uuf6429 January 11, 2025 13:51
src/Selenium2Driver.php Outdated Show resolved Hide resolved
src/Selenium2Driver.php Outdated Show resolved Hide resolved
tests/Selenium2Config.php Outdated Show resolved Hide resolved
src/Selenium2Driver.php Outdated Show resolved Hide resolved
@aik099 aik099 force-pushed the right-click-exception branch from 71e365b to 65301ae Compare January 11, 2025 19:24
@uuf6429
Copy link
Member

uuf6429 commented Jan 13, 2025

@aik099 I have some fixes built on top of your PR changes. How can I send the changes to you?

Never mind, I made a patch... here you go: tests-and-fixes.patch

  • SeleniumSupportTest.php - the 2 (new) tests mentioned earlier
  • Selenium2Driver.php - mainly, fixes for start() logic in particular:
    • throw DriverException instead of \Exception
    • do not catch DriverException immediately while trying to start - it's pointless
    • handle status() response structure in case of Selenium 4
  • Selenium2Config.php - many improvements:
    • refactored $testCase+$test usage
    • improved selenium version handling + added utility methods
    • utility methods are public, to be used in the test

@aik099
Copy link
Member Author

aik099 commented Jan 14, 2025

@aik099 I have some fixes built on top of your PR changes. How can I send the changes to you?

Never mind, I made a patch... here you go: tests-and-fixes.patch

  • SeleniumSupportTest.php - the 2 (new) tests mentioned earlier

  • Selenium2Driver.php - mainly, fixes for start() logic in particular:

    • throw DriverException instead of \Exception
    • do not catch DriverException immediately while trying to start - it's pointless
    • handle status() response structure in case of Selenium 4
  • Selenium2Config.php - many improvements:

    • refactored $testCase+$test usage
    • improved selenium version handling + added utility methods
    • utility methods are public, to be used in the test

@uuf6429 , I've tried to apply provided Patch in the PhpStorm and it had huge conflicts in several files. Are you sure, that you've created it based on last commit in this PR?

Anyway I've applied it, did some minor adjustments, pushed a few commits based on that.

Please see I haven't missed anything.

@aik099
Copy link
Member Author

aik099 commented Jan 18, 2025

@uuf6429 , ready for review.

@aik099 aik099 merged commit 4ad4a11 into minkphp:master Jan 18, 2025
13 checks passed
@aik099 aik099 deleted the right-click-exception branch January 18, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The "EventsTest::testRightClick" test fails on Selenium 3.x
2 participants