Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplication of code #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

defjam903
Copy link
Contributor

I am working on the same cracking the code book and was looking at others that completed the same system your code is the awesome, great job, but I noticed on the removing items from a link list program thee is no need for two functions to remove the file we are doing the work twice.

defjam903 added 2 commits July 8, 2017 09:26
i think there is no need for two remove functions we can do this with one remove function
Copy link
Owner

@minsuk-heo minsuk-heo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi, thanks for contribution, but
your change doesn't work if we remove first node in my linkedlist.
you can test removing 9 from your code.
Thanks.

@defjam903
Copy link
Contributor Author

good catch i t was late i forgot a section of code sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants