Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement PKCE to make public client more secure #196

Open
wants to merge 0 commits into
base: master
Choose a base branch
from

Conversation

iamnoah
Copy link

@iamnoah iamnoah commented Sep 27, 2022

This branch implements PKCE and randomizes the state parameter to add protections against replay attacks and some classes of compromised clients.

Because the client-secret has to be part of the .kube/config for all users, dex-k8s-authenticator is effectively a public client. Implementing PKCE means that an adversary who knows the client secret and is able to intercept URLs visited (and thus the authorization code) still has insufficient information to retrieve an access token because they lack the un-hashed code_verifier.

PKCE works with Dex without any additional configuration, for both types of client, so I've enabled it by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant