Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Report Schedules #4089

Open
wants to merge 24 commits into
base: main
Choose a base branch
from
Open

Delete Report Schedules #4089

wants to merge 24 commits into from

Conversation

Rieven
Copy link
Contributor

@Rieven Rieven commented Feb 12, 2025

Changes

  • Deletes both recipe OOI + schedule using the schedule id
  • Add Delete button to a schedule
  • Add delete modal with form to pass recipe id and schedule id to delete both.
  • Use delete schedule api anedpoint to delete schedule
  • Add delete schedule to SchedulerView client to handle exceptions

Issue link

#3959

Closes #3959

Demo

Screen.Recording.2025-02-12.at.13.51.27.mov

QA notes

  • Create a schedule by just creating a new report
  • Go to the reports schedules list
  • Delete schedule (button is found in the expando row

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@Rieven Rieven requested a review from a team as a code owner February 12, 2025 11:16
@jpbruinsslot
Copy link
Contributor

Tested the functionality and no issues found of broken references in Rocky. However in the scheduler the schedule_id of the tasks should have been set to None. This is however not the case. I'm investigating this issue here: #4101

This should not be blocking for this PR.

Copy link
Contributor

@Donnype Donnype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for processing the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementation: delete report recipe
5 participants