Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mip iframe 增加 https 检查、ascii 转码、src 和 srcdoc 属性监听 #329

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

clark-t
Copy link
Contributor

@clark-t clark-t commented Nov 1, 2018

相关 ISSUE: (ISSUE 链接地址)
#303

1、升级点 (清晰准确的描述升级的功能点)

  1. src 增加 https 检查
  2. 增加 ‘‘encode’’ 属性增加对 srcdoc 内容的 ascii 转码
  3. 增加对 src 和 srcdoc 的属性监听

2、影响范围 (描述该需求上线会影响什么功能)

  1. 对现有 mip-iframe 的使用方法不变
  2. 新增功能

3、自测 Checklist

4、需要覆盖的场景和 Case

  • 是否覆盖了 sf 打开 MIP 页
  • 是否验证了极速服务 MIP 页面效果

5、自测机型和浏览器

  • 是否覆盖了 iOS 系统手机
  • 是否覆盖了 Android 系统手机
  • 是否覆盖了 iPhone 版式浏览器(比如 QQ、UC、Chrome、Safari、安卓自带浏览器)
  • 是否覆盖了手百

@coveralls
Copy link

coveralls commented Nov 1, 2018

Pull Request Test Coverage Report for Build 560

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2166 unchanged lines in 58 files lost coverage.
  • Overall coverage decreased (-65.4%) to 28.451%

Files with Coverage Reduction New Missed Lines %
src/components/mip-fixed.js 1 75.0%
src/components/mip-shell/util.js 1 60.0%
src/page/util/feature-detect.js 1 92.86%
src/custom-element-store.js 2 73.68%
src/mip1-polyfill/index.js 3 82.76%
src/page/router/history.js 3 83.33%
src/util/dom/rect.js 5 59.38%
src/log/log-send.js 5 0.0%
src/util/dom/event.js 6 57.14%
src/vue-custom-element/utils/helpers.js 6 35.71%
Totals Coverage Status
Change from base Build 557: -65.4%
Covered Lines: 1047
Relevant Lines: 3342

💛 - Coveralls

@easonyq easonyq closed this Nov 22, 2018
@yenshih yenshih deleted the feat-mip-iframe-https branch December 25, 2018 07:06
@clark-t clark-t restored the feat-mip-iframe-https branch September 10, 2019 11:18
@clark-t clark-t reopened this Sep 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants