-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with Python 3.11 #104
base: master
Are you sure you want to change the base?
Conversation
Looks good, tested against Ubuntu Lunar + Python 3.11. |
Applies the same fix as an accepted pull request for |
Maybe someone with commit access could press the merge button? |
@heyman could you update the description to add the text |
Yep, good thinking. The following should replicate the problem: fnmatch_filter(names=["__init__.py"], pat="*.py") (on Python3.10, this emits a |
Ok, done! Hopefully someone with commit access can press the merge button for this tiny fix that makes it possible to use the package on Python 3.11. |
cc @miracle2k |
@heyman since this project is not maintained anymore, should we fork it under an organization and apply requires patches? |
@vad I'm currently using my fork. I don't have time to make it any more "official" than that, but if someone would setup a proper fork (and perhaps even create a new PyPI package) I'd applaud it :). |
This fixes a crash on Python 3.11. Global flags in regexes must now be put at the beginning.
This is the error message for the exception that this PR fixes:
re.error: global flags not at the start of the expression at position 12
Resolves #98