Iterate over nodes and templates using nodelist #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When iterating over Template and Node objects directly, nodes may fail with an exception such as: TypeError: 'TextNode' object is not iterable This is due to iterating over nodes being unsupported in Django, as noted in https://code.djangoproject.com/ticket/7430 To avoid this error, explicitly iterate over the nodelist attribute, rather than relying on __iter__.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When iterating over Template and Node objects directly, nodes may fail with an exception such as:
TypeError: 'TextNode' object is not iterable
This is due to iterating over nodes being unsupported in Django, as noted in https://code.djangoproject.com/ticket/7430
To avoid this error, explicitly iterate over the nodelist attribute, rather than relying on iter.
This fixes the issue seen in #101