-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update CI scripts #1039
Merged
Merged
chore: update CI scripts #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MisterDA
force-pushed
the
ci
branch
6 times, most recently
from
June 20, 2024 13:45
68d9490
to
6843ef4
Compare
I think this is ready for review. Sorry for the previous force-pushes. |
samoht
reviewed
Jun 21, 2024
"ounit" {with-test} | ||
"alcotest" {with-test} | ||
"ounit2" {with-test} | ||
"alcotest" {with-test & >= "1.7.0"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need more dependencies here:
cohttp-curl-async.opam: changes needed:
"async_kernel" {with-test} [from cohttp-curl-async/test] (missing {with-test} annotation)
"async_unix" {with-test} [from cohttp-curl-async/test] (missing {with-test} annotation)
"core_kernel" {with-test & >= "v0.16.0"} [from cohttp-curl-async/test]
rgrinberg
reviewed
Jun 24, 2024
Moved the ocamlformat commit into a separate PR #1044 to unblock the nix clean up. |
MisterDA
force-pushed
the
ci
branch
4 times, most recently
from
June 24, 2024 09:17
04ed841
to
3cba403
Compare
Signed-off-by: Antonin Décimo <[email protected]>
Signed-off-by: Antonin Décimo <[email protected]>
Signed-off-by: Antonin Décimo <[email protected]>
Add its own build job. Signed-off-by: Antonin Décimo <[email protected]>
Signed-off-by: Antonin Décimo <[email protected]>
Signed-off-by: Antonin Décimo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the GitHub Actions scripts for internal dependencies, updates cohttp test dependencies lower bounds, applies ocamlformat, then splits jobs between "default" (lwt and mirage), "async", "eio", and "bench" groups, to avoid conflicts. Finally, only 4.14 and 5.2 remain in testing with afl.
The CI doesn't pass yet because it's awaiting fixes for deprecation warnings from #1040, and the Ubuntu Snap Store seems currently down.