Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: new lwt server bugs #1048

Merged
merged 1 commit into from
Jun 27, 2024
Merged

fix: new lwt server bugs #1048

merged 1 commit into from
Jun 27, 2024

Conversation

rgrinberg
Copy link
Member

  • cannot call direct access recursively
  • we need to catch conn_reset

Signed-off-by: Rudi Grinberg [email protected]

@rgrinberg rgrinberg force-pushed the ps/rr/fix__new_lwt_server_bugs branch 2 times, most recently from d6a5d61 to e9e70ff Compare June 26, 2024 00:35
@rgrinberg
Copy link
Member Author

[nix-shell:~/github/mirage/ocaml-cohttp]$ wrk -c 10000 http://0.0.0.0:8080
Running 10s test @ http://0.0.0.0:8080
  2 threads and 10000 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     2.90ms  393.44us  14.28ms   78.55%
    Req/Sec    43.35k     3.18k   49.64k    68.50%
  862623 requests in 10.02s, 1.68GB read
  Socket errors: connect 9749, read 92, write 0, timeout 0
Requests/sec:  86073.66
Transfer/sec:    171.89MB

[nix-shell:~/github/mirage/ocaml-cohttp]$ wrk -c 10000 http://0.0.0.0:8080
Running 10s test @ http://0.0.0.0:8080
  2 threads and 10000 connections
  Thread Stats   Avg      Stdev     Max   +/- Stdev
    Latency     2.62ms    1.10ms  45.98ms   84.59%
    Req/Sec    46.79k     4.34k   53.53k    79.50%
  931481 requests in 10.03s, 1.84GB read
  Socket errors: connect 9749, read 96, write 0, timeout 0
Requests/sec:  92853.50
Transfer/sec:    187.55MB

The first result is for the new lwt sever, and the second is for the old. Note the max latency is much lower (although still kind of high)

* cannot call direct access recursively
* we need to catch conn_reset

Signed-off-by: Rudi Grinberg <[email protected]>

<!-- ps-id: c1719f95-0851-4245-8948-61a975d97f1d -->
@rgrinberg rgrinberg force-pushed the ps/rr/fix__new_lwt_server_bugs branch from e9e70ff to a8b3d26 Compare June 26, 2024 00:42
@rgrinberg rgrinberg merged commit fe388bb into master Jun 27, 2024
6 of 36 checks passed
@rgrinberg rgrinberg deleted the ps/rr/fix__new_lwt_server_bugs branch June 27, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant