Custom mh and mw icons for fisch #5849
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding custom logos for fisch
RhinosF1
reviewed
Mar 6, 2025
RhinosF1
approved these changes
Mar 6, 2025
|
I don't think this will work as fisch.miraheze.org (or a custom domain if any) would not be able to load resources cross-origin to hybridcafe.wiki thanks to the CSP. The images used should ideally be uploaded to fischwiki, and then the static.wikitide.net links used here. |
|
@BlankEclair I've changed it to cafe.miraheze.org. I won't upload it for now directly due to licensing issues. |
AgentIsai
reviewed
Mar 6, 2025
| 'alt' => 'Powered by MediaWiki', | ||
| ], | ||
| 'miraheze' => [ | ||
| 'src' => 'https://cafe.miraheze.org/w/img_auth.php/8/81/Miraheze_badge.svg', |
There was a problem hiding this comment.
Why use img_auth combined with serving directly from the wiki rather than a direct connection to static.wikitide.net?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding custom mh and mw icons for fisch