Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix all the slash warning in scss #697

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Conversation

erase2004
Copy link
Contributor

續: #642

修正 node-sass 更換為 dart-sass/ 不再作為除法使用所導致的 warning,由於 dart-sass 在 2.0 會完全棄用這個功能,
參考官方建議,修正既有相關 warning 所提示的程式區塊,
並建立一個 scss 檔案,使用 @nuxtjs/style-resources 來進行全域載入,確保 @use 語法在最上層。

ref:

@erase2004 erase2004 requested review from kwhsiung, v61265, dyfu95 and kjwen310 and removed request for kwhsiung and v61265 July 5, 2022 04:18
Copy link
Contributor

@kjwen310 kjwen310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

Copy link
Contributor

@dyfu95 dyfu95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
感謝幫忙修正scss

@v61265
Copy link
Contributor

v61265 commented Jul 6, 2022

LGTM!!!

@erase2004 erase2004 merged commit c6ae1ef into mirror-media:dev Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants