Fix bugs of the openssl-related on the abyss server in the advanced edition #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Every time the abyss server receives HTTP requests from a client underlying the SSL connection, file descriptors used in the socket API increases. So I'm fixing that a file descriptor is closed when channelDestroy() is called. Along with that, I'm fixing that the file descriptor is set to channelOpenSslP->fd in makeChannelFromSsl().
*Memory is leaked because memory of unused the channelOpenSslP object not been freed. So I'm fix that unused the channelOpenSslP is deleted in createChannelFromAcceptedConn()
* Memory is leaked because memory of allocated the sslP object of SSL structure not been freed. So I'm fix that allocated the sslP is freed by SSL_free() in channelDestroy()
* Since bin files are not installed to a directory by the specified prefix.
* Since openssl-related header file is not installed, even if HAVE_OPENSSL is "yes".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using the xmlrpc-c library for the openssl of the abyss server in the advanced edition.
But some glitches occurred in using the library.
So I have fixed them.
Could you please check and pull it.