Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MS-880 feat: add language select modal #191

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PrzemyslawPolrolniczak
Copy link

task https://mirumee.atlassian.net/browse/MS-880

As I've never used many technologies that you have in this project (newest Next.js version, Shadcn, Tailwind), and the figma design UX is abysmal, there are a lot of things to adjust for more experienced person in that project / technologies

Things left to do:

  • Responsiveness
  • Add proper icon instead of X string for closing the modal
  • Replace rgba colors with proper tailwind classes

btw. I still think Tailwind is utter shit

Pull Request Checklist

  • Test the changes locally to ensure they work as expected.
  • Document the testing process and results in the pull request description. (Screen recording, screenshot etc)
  • Include new tests for any new functionality or significant changes.
  • Ensure that tests cover edge cases and potential failure points.
  • Document the impact of the changes on the system, including potential risks and benefits.
  • Provide a rollback plan in case the changes introduce critical issues.
  • Update documentation to reflect any changes in functionality.

Copy link

vercel bot commented Feb 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nimara-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2025 0:24am
nimara-ecommerce ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 25, 2025 0:24am

@soniaklimas soniaklimas changed the base branch from main to develop March 3, 2025 13:12
@soniaklimas soniaklimas changed the base branch from develop to main March 3, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant