Fix skip with topics

misery · Jul 8, 2024 · 1f7c865 · 1f7c865
1 parent 78b8fc6
commit 1f7c865
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/contrib/mercurial_git_push.py b/contrib/mercurial_git_push.py
@@ -445,17 +445,18 @@ def summary(self):
 
     def skippable(self):
         if self._skippable is None:
+            self._skippable = False
             regex = r'Reviewed at https://'
 
             for changeset in self._changesets:
                 if changeset.summary().startswith('SKIP'):
                     self._skippable = True
                     self._failure = 'Starts with SKIP'
+                    break
                 elif re.search(regex, changeset.desc()):
                     self._skippable = True
                     self._failure = 'Description contains: "%s"' % regex
-                else:
-                    self._skippable = False
+                    break
 
         return self._skippable