Fix examples links in README.md #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mishina2228
reviewed
Oct 14, 2023
| * [Rails](https://mishina2228.github.io/git_stats/rails) | ||
| * [React](https://mishina2228.github.io/git_stats/react) | ||
| * [Vue](https://mishina2228.github.io/git_stats/vue) | ||
| * [Bootstrap](https://mishina2228.github.io/nova_git_stats_sample/bootstrap/) |
There was a problem hiding this comment.
Is the last slash redundant?
There was a problem hiding this comment.
Yes, the slash is redundant.
I would recommand to ADD the slash to all the URL to make it clear it is a directory.
I will update my patch.
LudovicRousseau
force-pushed
the
patch-1
branch
from
2165077 to
5f4d6db
Compare
mishina2228
reviewed
Oct 14, 2023
The URLs for the examples were not correct.
LudovicRousseau
force-pushed
the
patch-1
branch
from
5f4d6db to
529ede2
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The URLs for the examples were not correct.