This repository has been archived by the owner on Feb 11, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 572
Spot Instances, includes tagging and EBS #430
Open
3vcloud
wants to merge
4
commits into
mitchellh:master
Choose a base branch
from
3vcloud:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added code changes from https://github.com/3vcloud/vagrant-aws , thanks to https://github.com/KariusDx/vagrant-aws This commit allows spot instances to be created; the process in synchronous - waiting for the spot request to be successful before continuing. Cancels spot request after server is up.
…icts when cloning this repo instead of the original.
@@ -153,6 +154,10 @@ This provider exposes quite a few provider-specific configuration options: | |||
* `unregister_elb_from_az` - Removes the ELB from the AZ on removal of the last instance if true (default). In non default VPC this has to be false. | |||
* `terminate_on_shutdown` - Indicates whether an instance stops or terminates | |||
when you initiate shutdown from the instance. | |||
|
|||
* `spot_instance` - Boolean value; indicates whether the config is for a spot instance, or on-demand. For more information about spot instances, see the [AWS Documentation](http://docs.aws.amazon.com/AWSEC2/latest/UserGuide/how-spot-instances-work.html) | |||
* `max_spot_price` - Decimal value; state the maximum bid for your spot instance. Ignored if `spot_instance` is not true. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be spot_max_price
.
Running without any tags produce error:
|
Conflicts: lib/vagrant-aws/version.rb
Is this pull request still being moved forward, or should someone else pick it up? |
Does this pull request interest to other people? I am really interested in this feature. |
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forked original vagrant-aws repo to be able to submit pull request.
Added code changes from https://github.com/3vcloud/vagrant-aws , thanks to https://github.com/KariusDx/vagrant-aws for original spot functionality.
This commit allows spot instances to be created; the process in synchronous - waiting for the spot request to be successful before continuing. Cancels spot request after server is up.