Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add canvas integration support #300

Merged
merged 1 commit into from
Nov 3, 2022

Conversation

arslanashraf7
Copy link

@arslanashraf7 arslanashraf7 commented Oct 31, 2022

Related ticket

#299

What this PR does?

  • Cherry-picks the Canvas integration from Nutmeg to Olive (Mentioned in the ticket)
  • Refactors the code a little to fix the conflicts

How should this be tested?

@arslanashraf7
Copy link
Author

arslanashraf7 commented Nov 1, 2022

There are two checks failing but they are not related to any changes in this PR, The same is also failing on our fork on master and I suspect they are related to the environment the checks are running in so they shouldn't effect us.

@asadali145 asadali145 self-requested a review November 2, 2022 13:12
Copy link

@asadali145 asadali145 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!👏🏻

@asadali145 asadali145 self-assigned this Nov 3, 2022
@arslanashraf7 arslanashraf7 merged this pull request into mitx/olive Nov 3, 2022
@arslanashraf7 arslanashraf7 deleted the arslan/299-canvas-pick branch November 3, 2022 07:56
blarghmatey pushed a commit that referenced this pull request Jun 26, 2023
blarghmatey pushed a commit that referenced this pull request Nov 16, 2023
blarghmatey pushed a commit that referenced this pull request May 21, 2024
(cherry picked from commit 98522f7)
(cherry picked from commit 71b7ca0)
(cherry picked from commit fa70b41a1ce4177cb6d0d0c1e881fbe98cb82d48)
(cherry picked from commit d2e53c92630467444a5036bf2756ec0d0acbea66)
blarghmatey pushed a commit that referenced this pull request May 21, 2024
(cherry picked from commit 98522f7)
(cherry picked from commit 71b7ca0)
blarghmatey pushed a commit that referenced this pull request Jun 9, 2024
(cherry picked from commit 98522f7)
(cherry picked from commit 71b7ca0)
(cherry picked from commit fa70b41a1ce4177cb6d0d0c1e881fbe98cb82d48)
(cherry picked from commit d2e53c92630467444a5036bf2756ec0d0acbea66)
(cherry picked from commit 0f3333f5a3376abb989a74ce7dfe3676db28a83e)
blarghmatey pushed a commit that referenced this pull request Jun 13, 2024
(cherry picked from commit 98522f7)
(cherry picked from commit 71b7ca0)
(cherry picked from commit fa70b41a1ce4177cb6d0d0c1e881fbe98cb82d48)
(cherry picked from commit d2e53c92630467444a5036bf2756ec0d0acbea66)
(cherry picked from commit 0f3333f5a3376abb989a74ce7dfe3676db28a83e)
blarghmatey pushed a commit that referenced this pull request Jun 17, 2024
(cherry picked from commit 98522f7)
(cherry picked from commit 71b7ca0)
(cherry picked from commit fa70b41a1ce4177cb6d0d0c1e881fbe98cb82d48)
(cherry picked from commit d2e53c92630467444a5036bf2756ec0d0acbea66)
(cherry picked from commit 0f3333f5a3376abb989a74ce7dfe3676db28a83e)
blarghmatey pushed a commit that referenced this pull request Jun 18, 2024
(cherry picked from commit 98522f7)
(cherry picked from commit 71b7ca0)
(cherry picked from commit fa70b41a1ce4177cb6d0d0c1e881fbe98cb82d48)
(cherry picked from commit d2e53c92630467444a5036bf2756ec0d0acbea66)
(cherry picked from commit 0f3333f5a3376abb989a74ce7dfe3676db28a83e)
blarghmatey pushed a commit that referenced this pull request Jun 20, 2024
(cherry picked from commit 98522f7)
(cherry picked from commit 71b7ca0)
(cherry picked from commit fa70b41a1ce4177cb6d0d0c1e881fbe98cb82d48)
(cherry picked from commit d2e53c92630467444a5036bf2756ec0d0acbea66)
(cherry picked from commit 0f3333f5a3376abb989a74ce7dfe3676db28a83e)
blarghmatey pushed a commit that referenced this pull request Jul 23, 2024
(cherry picked from commit 98522f7)
(cherry picked from commit 71b7ca0)
(cherry picked from commit fa70b41a1ce4177cb6d0d0c1e881fbe98cb82d48)
(cherry picked from commit d2e53c92630467444a5036bf2756ec0d0acbea66)
(cherry picked from commit 0f3333f5a3376abb989a74ce7dfe3676db28a83e)
blarghmatey pushed a commit that referenced this pull request Jul 29, 2024
(cherry picked from commit 98522f7)
(cherry picked from commit 71b7ca0)
(cherry picked from commit fa70b41a1ce4177cb6d0d0c1e881fbe98cb82d48)
(cherry picked from commit d2e53c92630467444a5036bf2756ec0d0acbea66)
(cherry picked from commit 0f3333f5a3376abb989a74ce7dfe3676db28a83e)
blarghmatey pushed a commit that referenced this pull request Jul 29, 2024
(cherry picked from commit 98522f7)
(cherry picked from commit 71b7ca0)
blarghmatey pushed a commit that referenced this pull request Aug 2, 2024
(cherry picked from commit 98522f7)
(cherry picked from commit 71b7ca0)
(cherry picked from commit fa70b41a1ce4177cb6d0d0c1e881fbe98cb82d48)
(cherry picked from commit d2e53c92630467444a5036bf2756ec0d0acbea66)
(cherry picked from commit 0f3333f5a3376abb989a74ce7dfe3676db28a83e)
blarghmatey pushed a commit that referenced this pull request Aug 7, 2024
(cherry picked from commit 98522f7)
(cherry picked from commit 71b7ca0)
blarghmatey pushed a commit that referenced this pull request Aug 7, 2024
(cherry picked from commit 98522f7)
(cherry picked from commit 71b7ca0)
(cherry picked from commit fa70b41a1ce4177cb6d0d0c1e881fbe98cb82d48)
(cherry picked from commit d2e53c92630467444a5036bf2756ec0d0acbea66)
(cherry picked from commit 0f3333f5a3376abb989a74ce7dfe3676db28a83e)
blarghmatey pushed a commit that referenced this pull request Aug 20, 2024
(cherry picked from commit 98522f7)
(cherry picked from commit 71b7ca0)
(cherry picked from commit fa70b41a1ce4177cb6d0d0c1e881fbe98cb82d48)
(cherry picked from commit d2e53c92630467444a5036bf2756ec0d0acbea66)
(cherry picked from commit 0f3333f5a3376abb989a74ce7dfe3676db28a83e)
blarghmatey pushed a commit that referenced this pull request Sep 25, 2024
(cherry picked from commit 98522f7)
(cherry picked from commit 71b7ca0)
(cherry picked from commit fa70b41a1ce4177cb6d0d0c1e881fbe98cb82d48)
(cherry picked from commit d2e53c92630467444a5036bf2756ec0d0acbea66)
(cherry picked from commit 0f3333f5a3376abb989a74ce7dfe3676db28a83e)
arslanashraf7 added a commit that referenced this pull request Oct 28, 2024
(cherry picked from commit 98522f7)
(cherry picked from commit 71b7ca0)
(cherry picked from commit fa70b41a1ce4177cb6d0d0c1e881fbe98cb82d48)
(cherry picked from commit d2e53c92630467444a5036bf2756ec0d0acbea66)
(cherry picked from commit 0f3333f5a3376abb989a74ce7dfe3676db28a83e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants