forked from openedx/edx-platform
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add canvas integration support #300
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two checks failing but they are not related to any changes in this PR, The same is also failing on our fork on master and I suspect they are related to the environment the checks are running in so they shouldn't effect us. |
asadali145
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!👏🏻
blarghmatey
pushed a commit
that referenced
this pull request
Apr 11, 2023
blarghmatey
pushed a commit
that referenced
this pull request
Jun 26, 2023
(cherry picked from commit 98522f7)
blarghmatey
pushed a commit
that referenced
this pull request
Nov 16, 2023
(cherry picked from commit 98522f7)
blarghmatey
pushed a commit
that referenced
this pull request
May 21, 2024
blarghmatey
pushed a commit
that referenced
this pull request
May 21, 2024
blarghmatey
pushed a commit
that referenced
this pull request
Jul 29, 2024
blarghmatey
pushed a commit
that referenced
this pull request
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related ticket
#299
What this PR does?
How should this be tested?
Install https://github.com/mitodl/open-edx-plugins/tree/main/src/ol_openedx_canvas_integration (Follow the readme instructions) or just
pip install ol-openedx-canvas-integration
Restart edx instance, notice you are able to see the
Canvas
tab underInstructor Dashboard
Set canvas course id in your test course through Studio's Advanced Settings
Make sure that all the Canvas functionality works fine (Functionality is mostly mentioned in https://github.com/mitodl/open-edx-plugins/tree/main/src/ol_openedx_canvas_integration)
You will need values for (You can ask for these keys from me or Devops folks):
CANVAS_BASE_URL
CANVAS_ACCESS_TOKEN
Some more testing instructions are on feat: Added Canvas support #274