fix: fix config name from MARKETING_BASE_URL to MARKETING_SITE_BASE_URL #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* refactor: added configurable and consistant footer as per MITX specifications. * fix(packge.json): add MITX info * fix: updated packge name * fix: updated author name * refactor: added prepare script * fix: updated read me and removed prepare scrpt * fix: updated packages to resolve conflicts * fix: added caret ranges * fix: updated node version * docs: fix typos (#8) * refactor: update package-lock * fix: fix failing tests --------- Co-authored-by: Wassaf-Shahzad <[email protected]> Co-authored-by: Arslan Ashraf <[email protected]>
* feat: add accessibility link * feat: add a test for the accessibility link * refactor: lint
blarghmatey
approved these changes
Dec 22, 2023
|
@blarghmatey Should we merge this PR or can we rebase the footer with upstream changes? This commit is merged in the Open edX footer as well openedx#381. |
|
Closing as footer is rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Subtask of https://github.com/mitodl/hq/issues/3135
Description (What does it do?)
The config name for the marketing URL is MARKETING_SITE_BASE_URL but MARKETING_BASE_URL is used in the Footer and it is not getting picked up from the config. This PR just fixes the name of the config variable.
How can this be tested?
Screenshot