chore(deps): update dependency wagtail to v4 [security] #5362

renovate · 2023-10-24T17:50:23Z

This PR contains the following updates:

Package	Change	Age	Adoption	Passing	Confidence
wagtail (source, changelog)	`==2.12.5` -> `==4.1.9`

GitHub Vulnerability Alerts

CVE-2023-28836

Impact

A stored cross-site scripting (XSS) vulnerability exists on ModelAdmin views within the Wagtail admin interface. A user with a limited-permission editor account for the Wagtail admin could potentially craft pages and documents that, when viewed by a user with higher privileges, could perform actions with that user's credentials. The vulnerability is not exploitable by an ordinary site visitor without access to the Wagtail admin, and only affects sites with ModelAdmin enabled.

For page, the vulnerability is in the "Choose a parent page" ModelAdmin view (ChooseParentView), available when managing pages via ModelAdmin.
For documents, the vulnerability is in the ModelAdmin Inspect view (InspectView) when displaying document fields.

Patches

Patched versions have been released as Wagtail 4.1.4 (for the LTS 4.1 branch) and Wagtail 4.2.2 (for the current 4.2 branch).

Workarounds

Site owners who are unable to upgrade to the new versions can disable or override the corresponding functionality.

`ChooseParentView`

For ChooseParentView:

Disable ModelAdmin for all page models.
Or provide a custom view via choose_parent_view_class, with the custom view overriding the get_form method.

One of those steps need to be applied for every ModelAdmin class hooked into Wagtail where the model is a Wagtail Page or sub-class. Here is an example of implementing the custom ChooseParentView with patched HTML escaping:

from django import forms
from django.utils.translation import gettext as _
from wagtail.contrib.modeladmin.views import ChooseParentView
from wagtail.contrib.modeladmin.forms import ParentChooserForm

class PatchedPageChoiceField(forms.ModelChoiceField):
    """PageChoiceField with plain-text breadcrumbs to patch stored XSS."""
    def label_from_instance(self, obj):
        bits = []
        for ancestor in (
            obj.get_ancestors(inclusive=True).exclude(depth=1).specific(defer=True)
        ):
            bits.append(ancestor.get_admin_display_title())
        return ' | '.join(bits)

class PatchedParentChooserForm(ParentChooserForm):
    """ParentChooserForm with custom parent_page to patch stored XSS."""
    parent_page = PatchedPageChoiceField(
        label=_("Parent page"),
        required=True,
        empty_label=None,
        queryset=Page.objects.none(),
        widget=forms.RadioSelect(),
    )

class PatchedChooseParentView(ChooseParentView):
    """ChooseParentView with custom get_form patch stored XSS."""
    def get_form(self, request):
        parents = self.permission_helper.get_valid_parent_pages(request.user)
        return PatchedParentChooserForm(parents, request.POST or None)

`InspectView`

For InspectView:

Remove inspect_view_enabled=True or set it to False to disable the view.
Or use inspect_view_fields or inspect_view_fields_exclude to prevent displaying document fields in the views.
Or provide a custom view via inspect_view_class, with the custom view overriding the get_document_field_display method.

One of those steps need to be applied for every ModelAdmin class hooked into Wagtail where inspect_view_enabled=True. Here is an example of implementing the custom InspectView with patched HTML escaping:

from django.template.defaultfilters import filesizeformat
from django.utils.html import format_html
from wagtail.contrib.modeladmin.views import InspectView

class PatchedInspectView(InspectView):
    """InspectView with override to patch stored XSS vulnerability."""
    def get_document_field_display(self, field_name, field):
        """Render a link to a document"""
        document = getattr(self.instance, field_name)
        if document:
            return format_html(
                '<a href="{}">{} <span class="meta">({}, {})</span></a>',
                document.url,
                document.title,
                document.file_extension.upper(),
                filesizeformat(document.file.size),
            )
        return self.model_admin.get_empty_value_display(field_name)

CVE-2023-28837

Impact

A memory exhaustion bug exists in Wagtail's handling of uploaded images and documents. For both images and documents, files are loaded into memory during upload for additional processing. A user with access to upload images or documents through the Wagtail admin interface could upload a file so large that it results in a crash or denial of service.

The vulnerability is not exploitable by an ordinary site visitor without access to the Wagtail admin. It can only be exploited by admin users with permission to upload images or documents.

Image uploads are restricted to 10MB by default, however this validation only happens on the frontend and on the backend after the vulnerable code.

Patches

Patched versions have been released as Wagtail 4.1.4 (for the LTS 4.1 branch) and Wagtail 4.2.2 (for the current 4.2 branch).

Workarounds

Site owners who are unable to upgrade to the new versions are encouraged to add extra protections outside of Wagtail to limit the size of uploaded files. Exactly how this is done will vary based on your hosting environment, but here are a few references for common setups:

Nginx: client_max_body_size
Apache: LimitRequestBody
Cloudflare: Already imposes a limit of 100MB - 500MB depending on plan
CloudFront: SizeConstraint
Traefik: traefik.http.middlewares.limit.buffering.maxRequestBodyBytes

The changes themselves are deep inside Wagtail, making patching incredibly difficult.

CVE-2023-45809

Impact

A user with a limited-permission editor account for the Wagtail admin can make a direct URL request to the admin view that handles bulk actions on user accounts. While authentication rules prevent the user from making any changes, the error message discloses the display names of user accounts, and by modifying URL parameters, the user can retrieve the display name for any user. The vulnerability is not exploitable by an ordinary site visitor without access to the Wagtail admin.

Patches

Patched versions have been released as Wagtail 4.1.9 (LTS), 5.0.5 and 5.1.3. The fix is also included in Release Candidate 1 of the forthcoming Wagtail 5.2 release.

Workarounds

None.

Acknowledgements

Many thanks to @quyenheu for reporting this issue.

For more information

If you have any questions or comments about this advisory:

Visit Wagtail's support channels
Email us at [email protected] (view our security policy for more information).

Release Notes

wagtail/wagtail (wagtail)

chore(deps): update dependency wagtail to v4 [security] #5362

Are you sure you want to change the base?

chore(deps): update dependency wagtail to v4 [security] #5362

Conversation

renovate bot commented Oct 24, 2023 • edited Loading

GitHub Vulnerability Alerts

CVE-2023-28836

Impact

Patches

Workarounds

ChooseParentView

InspectView

CVE-2023-28837

Impact

Patches

Workarounds

CVE-2023-45809

Impact

Patches

Workarounds

Acknowledgements

For more information

Release Notes

v4.1.9: 4.1.9

v4.1.8: 4.1.8

v4.1.7: 4.1.7

v4.1.6: 4.1.6

v4.1.5: 4.1.5

v4.1.4: 4.1.4

v4.1.3: 4.1.3

v4.1.2: 4.1.2

v4.1.1: 4.1.1

v4.1: 4.1

v4.0.4: 4.0.4

v4.0.3: 4.0.3

v4.0.2: 4.0.2

v4.0.1: 4.0.1

v4.0: 4.0

v3.0.3: 3.0.3

v3.0.2: 3.0.2

v3.0.1: 3.0.1

v3.0: 3.0

Configuration

renovate bot commented Oct 24, 2023 •

edited

Loading

`ChooseParentView`

`InspectView`

`v4.1.9`: 4.1.9

`v4.1.8`: 4.1.8

`v4.1.7`: 4.1.7

`v4.1.6`: 4.1.6

`v4.1.5`: 4.1.5

`v4.1.4`: 4.1.4

`v4.1.3`: 4.1.3

`v4.1.2`: 4.1.2

`v4.1.1`: 4.1.1

`v4.1`: 4.1

`v4.0.4`: 4.0.4

`v4.0.3`: 4.0.3

`v4.0.2`: 4.0.2

`v4.0.1`: 4.0.1

`v4.0`: 4.0

`v3.0.3`: 3.0.3

`v3.0.2`: 3.0.2

`v3.0.1`: 3.0.1

`v3.0`: 3.0