drawer topic carousels should not be filtered on just courses #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) => ResourceCarouselProps["config"] | ||
|
|
||
| const TopicCarouselConfig: TopicCarouselConfigProps = ( | ||
| topic: string | undefined, | ||
| resourceType?: LearningResourcesSearchRetrieveResourceTypeEnum[] | undefined, |
There was a problem hiding this comment.
resourceTypes ? or maybe filteredTypes ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
https://github.com/mitodl/hq/issues/6565
Description (What does it do?)
When adding the topic carousels to the new learning resource drawer, the
TopicCarouselConfigclass was reused from the Dashboard. This config was set up by default to filter on only courses. The carousels in the drawer are not supposed to be this way. By default theTopicCarouselConfigdoes not filter on courses now, and that is only set in the Dashboard.How can this be tested?
mit-learn