-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove ENABLE_BLOG & WEBINARS feature flags #3358
Conversation
refactor: more removals test: fix tests
47ccbe0
to
d523dbb
Compare
{% if news_and_events %} | ||
{% include "partials/news-and-events-carousel.html" with page=news_and_events %} | ||
{% endif %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove the ability to add the news and events child page under the Home page in CMS as well. We still have the ability to add the news and events under Home page and this can get confusing at some point where people might think that the news and events would show up on HomePage is they add it through CMS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, sounds good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arslanashraf7 This should be all set now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
We will need to think of what to do with the existing News and Events page created under HomePage on CMS.
Also, Please merge this after geting @cachob's approval too
@cachob We have removed the feature flags for Webinar and Blog as they have been enabled on Prod for some time. Also, we removed the news and events section from the Home page.
Please let me know if this sounds good OR if you have any reservations. |
Sounds good - I agree with your assessment |
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/6366 & https://github.com/mitodl/hq/issues/6367
Description (What does it do?)
Removes the ENABLE_BLOG, and WEBINARS feature flags as it has been active for some time now.
How can this be tested?
Check out this branch. The blog and webinar links in the header should work. The links should not depend on any flag.