Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove ENABLE_BLOG & WEBINARS feature flags #3358

Merged
merged 5 commits into from
Jan 14, 2025

Conversation

asadali145
Copy link
Contributor

@asadali145 asadali145 commented Jan 8, 2025

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/6366 & https://github.com/mitodl/hq/issues/6367

Description (What does it do?)

Removes the ENABLE_BLOG, and WEBINARS feature flags as it has been active for some time now.

How can this be tested?

Check out this branch. The blog and webinar links in the header should work. The links should not depend on any flag.

@odlbot odlbot temporarily deployed to xpro-ci-pr-3358 January 8, 2025 13:55 Inactive
@asadali145 asadali145 changed the title refactor: remove ENABLE_BLOG feature flag refactor: remove ENABLE_BLOG & WEBINARS feature flags Jan 8, 2025
@odlbot odlbot temporarily deployed to xpro-ci-pr-3358 January 8, 2025 14:02 Inactive
@odlbot odlbot temporarily deployed to xpro-ci-pr-3358 January 8, 2025 14:05 Inactive
@odlbot odlbot temporarily deployed to xpro-ci-pr-3358 January 8, 2025 14:18 Inactive
@arslanashraf7 arslanashraf7 self-assigned this Jan 13, 2025
@asadali145 asadali145 force-pushed the asad/remove-enable-blog-flag branch from 47ccbe0 to d523dbb Compare January 13, 2025 10:09
@odlbot odlbot temporarily deployed to xpro-ci-pr-3358 January 13, 2025 10:09 Inactive
@odlbot odlbot temporarily deployed to xpro-ci-pr-3358 January 13, 2025 10:47 Inactive
Comment on lines -45 to -47
{% if news_and_events %}
{% include "partials/news-and-events-carousel.html" with page=news_and_events %}
{% endif %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove the ability to add the news and events child page under the Home page in CMS as well. We still have the ability to add the news and events under Home page and this can get confusing at some point where people might think that the news and events would show up on HomePage is they add it through CMS.

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, sounds good!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arslanashraf7 This should be all set now.

Copy link
Contributor

@arslanashraf7 arslanashraf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

We will need to think of what to do with the existing News and Events page created under HomePage on CMS.

Also, Please merge this after geting @cachob's approval too

@asadali145
Copy link
Contributor Author

@cachob We have removed the feature flags for Webinar and Blog as they have been enabled on Prod for some time.

Also, we removed the news and events section from the Home page.

  • We cannot create news and events page under the homepage, and it won't be displayed on the Homepage.

Please let me know if this sounds good OR if you have any reservations.

@cachob
Copy link

cachob commented Jan 14, 2025

Sounds good - I agree with your assessment

@asadali145 asadali145 merged commit 04cca6a into master Jan 14, 2025
7 checks passed
@asadali145 asadali145 deleted the asad/remove-enable-blog-flag branch January 14, 2025 05:59
@odlbot odlbot mentioned this pull request Jan 16, 2025
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants