Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add pull_request trigger #2020

Merged
merged 3 commits into from
Nov 15, 2023
Merged

Conversation

HussainTaj-arbisoft
Copy link
Contributor

@HussainTaj-arbisoft HussainTaj-arbisoft commented Nov 7, 2023

What are the relevant tickets?

Relates to #2015

Description (What does it do?)

We received a PR from a fork: #2015. The CI workflow is not configured to run on PRs.

This PR updates the triggers.

How can this be tested?

Just ensure that the syntax is correct.

@feoh
Copy link
Contributor

feoh commented Nov 14, 2023

This change looks structurally good to me. I've asked @pt2302 and/or @gumaerc to acknowledge that they're OK with this process change.

@feoh feoh self-assigned this Nov 14, 2023
@feoh
Copy link
Contributor

feoh commented Nov 14, 2023

Spoke with @pt2302 and he agrees this change is innocuous. Approved.

@HussainTaj-arbisoft HussainTaj-arbisoft merged commit 8f4ddf2 into master Nov 15, 2023
@HussainTaj-arbisoft HussainTaj-arbisoft deleted the hussaintaj/pr-ci-trigger branch November 15, 2023 06:21
@odlbot odlbot mentioned this pull request Nov 16, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants