Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues w/ form not passing on auth state #131

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

rhysyngsun
Copy link
Contributor

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/5923

Description (What does it do?)

This removes the html form + submit button combination because it needs to be a GET request but html forms erase the querystring when the method is GET. A plain anchor tag replaces it because this works the way it needs to.

How can this be tested?

  • In keycloak, create a user with no credentials or remove credentials from an existing one
  • Go to Learn, click "Login"
  • Enter the email address for the above user
  • You should be prompted to reset the password for that user
  • Perform the password reset
  • You should be redirected back to Learn instead of the keycloak account page

@rhysyngsun rhysyngsun added the Needs Review An open Pull Request that is ready for review label Jan 21, 2025
@cp-at-mit cp-at-mit removed the Needs Review An open Pull Request that is ready for review label Jan 21, 2025
@rhysyngsun rhysyngsun merged commit 2d491ce into main Jan 22, 2025
6 checks passed
@rhysyngsun rhysyngsun deleted the nl/fix-reset-redirect-url branch January 22, 2025 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants