Fix Apply Attestation: "TypeError: Cannot read properties of undefined (reading 'status')" #6616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts. Test added in the SAF CLI Signed-off-by: Emily Rodriguez <[email protected]>
Signed-off-by: Emily Rodriguez <[email protected]>
Amndeep7
requested changes
Feb 11, 2025
Signed-off-by: Amndeep Singh Mann <[email protected]>
|
Also I pushed up a commit @em-c-rod, feel free to revert if you don't want it. |
Signed-off-by: Emily Rodriguez <[email protected]>
Signed-off-by: Emily Rodriguez <[email protected]>
Signed-off-by: Emily Rodriguez <[email protected]>
|
Amndeep7
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When applying an attestation to an overlay file, we were getting the following error:
"TypeError: Cannot read properties of undefined (reading 'status')"because the overlay file had the same control listed in multiple profile objects of the HDF file. Not every control instance has results because of it being an overlay file. This will catch that issue and apply the attestation once the results exist.