fix: Hipcheck now works with scoped npm packages. #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mchernicoff
requested review from
j-lanson and
alilleybrinker
and removed request for
a team
|
Tests that were changed in another PR to main reverted back to the older form when I rebased. Fixing now. |
mchernicoff
force-pushed
the
mchernicoff/npm-scopes
branch
from
0b54f8c to
7f566c9
Compare
alilleybrinker
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Issue #235. Hipcheck will now include the scope for scoped NPM packages in the format
@scope/package@version.This works with NPM targets in
package@version, NPM registry URL, or pURL formats.