chore(refactor): distinguish TargetSeed and TargetSeedKind #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-lanson
force-pushed
the
jlanson/tgt-seed-kind
branch
from
ef43727 to
53a49e1
Compare
alilleybrinker
previously approved these changes
Jul 31, 2024
|
LGTM! There's a merge conflict that will just need to be resolved with a rebase. Ping me when it's fixed and I'll give a new approval 😄 |
…r ref info from cli
j-lanson
force-pushed
the
jlanson/tgt-seed-kind
branch
from
53a49e1 to
6f9cb00
Compare
alilleybrinker
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following a team discussion, this PR renames the existing
TargetSeedenum toTargetSeedKindand wraps it with a newTargetSeedstruct that allowsrefspecinfo to be passed from the CLI for non-local repos.This PR does not introduce git ref support for packages or SBOMs, it simply refactors the existing logic.