Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Move common-use crates into hc_common #37

Merged
merged 13 commits into from
May 1, 2024
Merged

feat: Move common-use crates into hc_common #37

merged 13 commits into from
May 1, 2024

Conversation

mchernicoff
Copy link
Contributor

As part of a general bookkeeping effort, this moves the following common-use crates into the hc_common crate:

  • hc_command_util
  • hc_error
  • hc_filesystem
  • hc_pathbuf
  • hc_test_util

@mchernicoff mchernicoff requested a review from alilleybrinker May 1, 2024 13:53
@mchernicoff
Copy link
Contributor Author

Open to suggestions to restructure hc_common with some nested folders inside src, if that makes things more legible code-wise.

@alilleybrinker
Copy link
Collaborator

Thanks! I think we can start here and then consider a module restructure after that. LGTM!

alilleybrinker
alilleybrinker previously approved these changes May 1, 2024
View reviewed changes
@alilleybrinker
Copy link
Collaborator

Ah, looks like there are conflicts preventing a rebase. @mchernicoff think you could resolve them? Happy to do it myself if that's easier.

@alilleybrinker
Copy link
Collaborator

Hm, looks like it didn't do the Conventional Commits checking in CI, which it should be doing now. So I'll also debug that

@mchernicoff
Copy link
Contributor Author

mchernicoff commented May 1, 2024 •
edited
Loading

@alilleybrinker I can do another rebase and check for conflicts.

@alilleybrinker
fix: Correct Conventional Commits workflow
831b2a1 
This commit fixes bad YAML indentation leading to the conventional
commits CI configuration being ignored previously.

Signed-off-by: Andrew Lilley Brinker <[email protected]>
@alilleybrinker
Copy link
Collaborator

@mchernicoff I just pushed a commit to this branch to (hopefully) fix the broken CI job for Conventional Commit checking.

@mchernicoff mchernicoff self-assigned this May 1, 2024
@mchernicoff mchernicoff requested a review from alilleybrinker May 1, 2024 17:28
@alilleybrinker
Copy link
Collaborator

Taking a look at the updates now!

@alilleybrinker
fix: Fixup minor test compile / fmt issues.
ffefe6d 
This commit fixes some minor issues with compiling default-ignored
tests, and also updates the CI config to make sure those cases are
caught in the future.

Signed-off-by: Andrew Lilley Brinker <[email protected]>
@alilleybrinker
Copy link
Collaborator

Okay @mchernicoff looks like it just needs a final review from you since I pushed some minor fixes to the PR branch. Then we're good to merge!

@alilleybrinker alilleybrinker merged commit d5fa061 into main May 1, 2024
4 checks passed
@alilleybrinker alilleybrinker added the type: enhancement New feature or request label May 1, 2024
@alilleybrinker alilleybrinker added this to the 3.2.0 milestone May 1, 2024
@alilleybrinker alilleybrinker linked an issue May 1, 2024 that may be closed by this pull request
Reduce crates in Hipcheck workspace #2
Closed
@alilleybrinker alilleybrinker deleted the mchernicoff/crates-to-common branch May 7, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alilleybrinker alilleybrinker alilleybrinker approved these changes

Assignees

@mchernicoff mchernicoff

Labels
type: enhancement New feature or request
Projects
Hipcheck Dev Roadmap
Status: Done
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

Reduce crates in Hipcheck workspace
2 participants
@mchernicoff @alilleybrinker