Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Move data type and retrieval crates into hc_data #39

Merged
merged 18 commits into from
May 1, 2024
Merged

feat: Move data type and retrieval crates into hc_data #39

merged 18 commits into from
May 1, 2024

Conversation

mchernicoff
Copy link
Contributor

As part of a general bookkeeping effort, this moves the following data related crates into the hc_data crate:

  • hc_eslint
  • hc_git
  • hc_github
  • hc_modules
  • hc_npm
  • hc_source

mchernicoff and others added 17 commits April 26, 2024 10:28
@mchernicoff
feat: Moves hc_error into hc_common. Currently not building pending b…
b710396 
…ug fixes.
@alilleybrinker
fix: Fix hc_error macro and imports
8bd2f6a 
This commit fixes a broken item path in the hc_error macro, and updates
imports of hc_common to reflect the new structure.

Signed-off-by: Andrew Lilley Brinker <[email protected]>
@mchernicoff
fix: formatting and other small issues
88271b8
@mchernicoff
Merge branch 'main' into mchernicoff/crates-to-common
166e3b7
@mchernicoff
fix: remaining conflict bugs
61b9f59
@mchernicoff
feat: Merge hc_command_util crate into hc_common
db80d7a
@mchernicoff
feat: Merge hc_filesysetm into hc_common
b376b34
@mchernicoff
fix: Added missing toml dependency to hc_cargo Cargo.toml
bf727fe
@mchernicoff
feat:Merge hc_pathbuf and hc_test_util into hc_common
06c8016
@mchernicoff
Merge branch 'main' into mchernicoff/crates-to-common
55af1cc
@mchernicoff
feat: Merge hc_eslint into hc_data
9be920d
@mchernicoff
feat: Merge hc_github into hc_data
0f7ce81
@mchernicoff
feat: Merge hc_modules into hc_data
be74a1f
@mchernicoff
feat: Merge hc_npm into hc_data
bc00232
@mchernicoff
feat: Merge hc_git and hc_source into hc_data
95e1c0b
@mchernicoff
Merge branch 'main' into mchernicoff/crates-to-data
9f97e65
@mchernicoff
fix: Resolve final merge conflicts
b0549f4
@mchernicoff mchernicoff requested a review from alilleybrinker May 1, 2024 19:30
@mchernicoff mchernicoff self-assigned this May 1, 2024
@mchernicoff mchernicoff changed the title Move data type and retrieval crates into hc_data feat: Move data type and retrieval crates into hc_data May 1, 2024
@alilleybrinker alilleybrinker merged commit ccb554d into main May 1, 2024
4 checks passed
@alilleybrinker
Copy link
Collaborator

Thanks @mchernicoff! Love to see the total Lines of Code go down! 🎉

@alilleybrinker alilleybrinker added the type: enhancement New feature or request label May 1, 2024
@alilleybrinker alilleybrinker added this to the 3.2.0 milestone May 1, 2024
@alilleybrinker alilleybrinker linked an issue May 1, 2024 that may be closed by this pull request
Reduce crates in Hipcheck workspace #2
Closed
@mchernicoff mchernicoff deleted the mchernicoff/crates-to-data branch May 9, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alilleybrinker alilleybrinker alilleybrinker approved these changes

Assignees

@mchernicoff mchernicoff

Labels
type: enhancement New feature or request
Projects
Hipcheck Dev Roadmap
Status: Done
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

Reduce crates in Hipcheck workspace
2 participants
@mchernicoff @alilleybrinker