chore: Complete unifying Hipcheck in single crate #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit eliminates the `hc_version` crate by moving its contents into `hc_common`. Signed-off-by: Andrew Lilley Brinker <[email protected]>
This commit moves `hc_config` into `hc_common`. Signed-off-by: Andrew Lilley Brinker <[email protected]>
This commit removes `hc_serde` in favor of directly importing `serde` where it's needed. Since everything will soon be merged into a single crate anyway it won't matter much. Signed-off-by: Andrew Lilley Brinker <[email protected]>
This commit merges the contents of `hc_report` into the `hc_common` crate. Signed-off-by: Andrew Lilley Brinker <[email protected]>
This commits merges `hc_shell` into `hc_common`. Signed-off-by: Andrew Lilley Brinker <[email protected]>
This commit merges `hc_data` into the `hc_common` crate. Signed-off-by: Andrew Lilley Brinker <[email protected]>
This commit merges `hc_core` and `hc_analysis` into `hc_common`. Signed-off-by: Andrew Lilley Brinker <[email protected]>
This completes the effort to unify Hipcheck into a single crate, by merging `hc_common` into `hipcheck`. Signed-off-by: Andrew Lilley Brinker <[email protected]>
It looks like Rustfmt had created some weird `::{self}`-imports. This
commit replaces them.
Signed-off-by: Andrew Lilley Brinker <[email protected]>
This commit removes the broken (and already minimally-useful) integration testing and benchmarking code. Those relied on the Hipcheck library interface, which no longer exists. We'll want to create new ones based on the new stable interface for Hipcheck, the CLI. Signed-off-by: Andrew Lilley Brinker <[email protected]>
This commit puts Hipcheck's dependencies in alphabetical order, which makes them much easier to work with in the future since there are so many of them. Signed-off-by: Andrew Lilley Brinker <[email protected]>
mchernicoff
previously approved these changes
May 7, 2024
I'd accidentally deleted the `#[serde(default)]` annotations on all of the configuration types, causing parsing to fail for config files if any fields were missing. This commit brings them back, and also resolves a clippy warning about a useless import. Signed-off-by: Andrew Lilley Brinker <[email protected]>
This commit fixes broken ureq TLS configuration. It turns out when you tell ureq to use native TLS certificate stores, it doesn't set those up in the request agent automatically the way it does for the default TLS configuration. Rather, it requires you to add the `native_tls` dependency and set them up yourself. This commit does that. Signed-off-by: Andrew Lilley Brinker <[email protected]>
This is why we have cross-platform CI testing haha. This commit removes a broken import in some Windows-specific code. We'd previously done a weird thing of re-exporting external dependencies under crate-local pathnames. We no longer do that, but had an import laying around still that expected this kind of structure. Signed-off-by: Andrew Lilley Brinker <[email protected]>
|
@mchernicoff ready for a re-review! |
mchernicoff
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.