Fix double-version command in xtask
#51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a runtime error that was stopping `cargo xtask` from running at all. Basically, we define a custom `--version` command, which was conflicting with the one automatically generated by `clap`, resulting in a runtime failure. This command just adds a line telling `clap` not to generate its own `version` flag, resolving the error and allowing `xtask` to run as expected. Signed-off-by: Andrew Lilley Brinker <[email protected]>
mchernicoff
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a runtime error that was stopping
cargo xtaskfrom running at all. Basically, we define a custom--versioncommand, which was conflicting with the one automatically generated byclap, resulting in a runtime failure.This command just adds a line telling
clapnot to generate its ownversionflag, resolving the error and allowingxtaskto run as expected.