Misc. cleanup tasks #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A while back I'd made a published crate called `pathbuf` that does the same stuff we'd been doing in our own `pathbuf.rs` file, so let's just use that instead of having our own code for it. Signed-off-by: Andrew Lilley Brinker <[email protected]>
This is intended to help clarify the folder structure in Hipcheck. We have some helper logic that wraps `std` functionality with nicer error messages, or extends iterators with helpful new methods, and those can now be found under the `util/` directory. Signed-off-by: Andrew Lilley Brinker <[email protected]>
Turns out at some point, probably with the Clap upgrade, that we'd broken the `--open` flag on the `cargo xtask doc` CLI. This commit fixes it, so you can use `cargo xtask doc --open` to see the internal API docs of the `hc` crate. Signed-off-by: Andrew Lilley Brinker <[email protected]>
alilleybrinker
added
type: bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
pathbufmodule with thepathbufcrate.util/module.cargo xtask doc --open.These should be rebase-merged without a squash.