chore: delete churn, entropy, typo from hipcheck core #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-lanson
reviewed
Nov 19, 2024
| concerns, | ||
| }) | ||
| } | ||
| } |
There was a problem hiding this comment.
You're on windows, and it seems like your setup doesn't include UNIX-style newlines at the ends of files. Please look for a way to fix this. You'll know when the commit diff here doesn't show a red circle.
hipcheck/src/analysis/mod.rs
Outdated
Comment on lines
141
to
78
| pub fn identity_analysis(db: &dyn AnalysisProvider) -> Result<QueryResult> { | ||
| let results = db.identity_metric()?; | ||
| let num_flagged = results | ||
| .matches | ||
| .iter() | ||
| .filter(|m| m.identities_match) | ||
| .count() as u64; | ||
| let percent_flagged = num_flagged as f64 / results.matches.len() as f64; | ||
| let value = F64::new(percent_flagged).expect("Percent threshold should never be NaN"); | ||
| Ok(QueryResult { | ||
| value: serde_json::to_value(value)?, | ||
| concerns: vec![], | ||
| }) | ||
| } | ||
|
|
There was a problem hiding this comment.
You've removed identity analysis as a function, might as well remove the definition of identity_metric()
bmarr-mitre
force-pushed
the
delete-entropy-churn-typo
branch
from
9cd91e1
to
b4979e3
Compare
|
deleting and resubmitting a different branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #640
Resolves #641
Resolves #642