chore: remove churn, entropy, typo from hipcheck core #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j-lanson
requested changes
Nov 22, 2024
There was a problem hiding this comment.
PR is not passing CI checks, view the failing CI test, it will tell you what you need to change. You can also run cargo clippy locally to view changes, and something like cargo clippy fix to fix the changes automatically. but be careful because in my experience sometimes the reported changes on the CI is a larger set.
bmarr-mitre
force-pushed
the
remove-churn-typo-entropy
branch
from
4e41f82
to
eded124
Compare
j-lanson
reviewed
Nov 22, 2024
bmarr-mitre
force-pushed
the
remove-churn-typo-entropy
branch
from
06baaa5
to
f078118
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #640
Resolves #641
Resolves #642