Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: CI improvements #887

Merged
merged 4 commits into from
Feb 5, 2025
Merged

chore: CI improvements #887

merged 4 commits into from
Feb 5, 2025

Conversation

j-lanson
Copy link
Collaborator

@j-lanson j-lanson commented Feb 5, 2025

Resolves #823 , Resolves #812 , Resolves #789 , Resolves #688 .

While in draft, I added a dummy commit to trigger the HC builds and tests that would not be triggered if I just updated the hipcheck.yml, so I have verified that our code running these updated actions will pass.

@j-lanson j-lanson force-pushed the jlanson/test-ci-changes branch 9 times, most recently from 6a8e3ad to 561bca0 Compare February 5, 2025 17:32
@j-lanson j-lanson force-pushed the jlanson/test-ci-changes branch 3 times, most recently from 6ada193 to a2a22dc Compare February 5, 2025 19:06
@j-lanson j-lanson changed the title chore: test - DO NOT MERGE THIS! chore: CI improvements Feb 5, 2025
@j-lanson j-lanson force-pushed the jlanson/test-ci-changes branch from 3391b04 to e5ddfc2 Compare February 5, 2025 19:09
@j-lanson j-lanson marked this pull request as ready for review February 5, 2025 19:10
@j-lanson j-lanson self-assigned this Feb 5, 2025
@j-lanson j-lanson added type: chore Clean up or management task. product: project Relates to the project itself labels Feb 5, 2025
Copy link
Collaborator

@alilleybrinker alilleybrinker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, otherwise LGTM! 👍🏻

@j-lanson j-lanson force-pushed the jlanson/test-ci-changes branch from e5ddfc2 to 19be2a9 Compare February 5, 2025 19:36
@j-lanson
Copy link
Collaborator Author

j-lanson commented Feb 5, 2025

Added the precise-builds line

@j-lanson
Copy link
Collaborator Author

j-lanson commented Feb 5, 2025

Did some local dist host and dist build commands to verify that precise-builds = true gives the desired behavior. Plugin tags now will only build that specific plugin instead of the entire workspace. Same for the hc core.

@j-lanson j-lanson merged commit 89bc059 into main Feb 5, 2025
7 checks passed
@alilleybrinker alilleybrinker deleted the jlanson/test-ci-changes branch February 11, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: project Relates to the project itself type: chore Clean up or management task.
Projects
No open projects
Status: Done
2 participants