Added --control-id flag #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd use a v3 RedHat xccdf |
|
Updated the RHEL7 V1R4 example profile to V3R3 |
rbclark
requested changes
May 7, 2021
rbclark
requested changes
May 12, 2021
Bialogs
force-pushed
the
xccdf2inspec_add_control_id_flag
branch
from
5191e74 to
f87e4bf
Compare
Bialogs
reviewed
May 13, 2021
…hey want the created profile to use legacy vuln IDs (ex. 'V-XXXXX') or rule IDs as the control IDs for the generated profile Signed-off-by: Will Dower <[email protected]>
Signed-off-by: Will Dower <[email protected]>
Signed-off-by: Will Dower <[email protected]>
Signed-off-by: Will Dower <[email protected]>
Signed-off-by: Will Dower <[email protected]>
Bialogs
force-pushed
the
xccdf2inspec_add_control_id_flag
branch
from
f87e4bf to
e87e92e
Compare
|
I think we left it a string so that we could eventually use any tag for the control_id as opposed to just a flag for using the legacy vulnID (which for now would need to default to true anyway). But the logic using the variable does expect it to be either ruleID or vulnID. |
|
note that there seem to be at least two ids hat are considered 'legecy' so it looks like it need to be an array |
Signed-off-by: Robert Clark <[email protected]>
rbclark
force-pushed
the
xccdf2inspec_add_control_id_flag
branch
3 times, most recently
from
94fece0 to
fa7c87a
Compare
We are already mapping over the legacy array so this shouldn't be an issue. |
Signed-off-by: Robert Clark <[email protected]>
rbclark
force-pushed
the
xccdf2inspec_add_control_id_flag
branch
from
fa7c87a to
8f849eb
Compare
rbclark
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added --control-id flag to xccdf2inspec to allow user to specify if they want the created profile to use legacy vuln IDs (ex. 'V-XXXXX') or rule IDs as the control IDs for the generated profile
resolves #218
Signed-off-by: Will Dower [email protected]