-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frozen ThreadState #107
base: master
Are you sure you want to change the base?
Frozen ThreadState #107
Conversation
288194d
to
bb38a86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review part 1. It's mostly about documentation / comments / docstrings to make everything super clear.
It's great that you already created unit tests at the drjit-core
level!
I still have to look at the big record_ts.*
files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review part 2
489f314
to
6a53f8f
Compare
7ea730c
to
e01f19a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review part 3.
It's a partial review of record_ts.cpp
, but unfortunately I won't have time to review the rest of the file, there's too much code.
this->init = rv.init; | ||
|
||
if (init == RecordVarInit::Captured) { | ||
// copy the variable, so that it isn't changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would that always match the behavior of no-recording?
I.e. if there are captured variables and I run the code with / without recording, would I always get the same result?
6439c0b
to
64a3dd7
Compare
64a3dd7
to
2915c3d
Compare
fa12537
to
24b6769
Compare
2adfdb3
to
21a8b62
Compare
21a8b62
to
e4ca159
Compare
@@ -0,0 +1,709 @@ | |||
/** Frozen function backend | |||
* | |||
* This file implements the backend for the `FrozenFunction` feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
This PR implements the Freezing feature in
drjit-core
(depends on #106).It makes the following changes:
jit.h
, including the following functions:jit_freeze_start
,jit_freeze_stop
,jit_freeze_replay
,jit_freeze_dry_run
,jit_freeze_pause
,jit_freeze_resume
,jit_freeze_abort
andjit_freeze_destroy
as well as theRecording
struct.RecordThreadState
, a wrapper around either the CUDA or LLVMThreadState
for freezing them.