Fix jit_scope issue with ordering mismatch between dict/xml and Properties #1410
+19
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM 🚀 Thanks Sébastien! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a concurrency issue occuring when loading large scenes in Mitsuba.
Currently the JIT scopes are based on the order of the objects in the dict / XML representation. On the other side, the instantiation of the objects follow the order defined by the
Propertiesdatastructure, which might differ.This patch ensures that the JIT scopes are created in the same order as the order used to launch asynchronous instantiations of objects, and seems to fix the errors we would see on our side.