Vendor yaml #465
Merged
Vendor yaml #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
github-merge-queue bot
pushed a commit
to near/nearcore
that referenced
this pull request
Mar 26, 2024
…arning (#10880) Recently `cargo audit` started complaining that the `yaml-rust` dependency is unmaintained (#10876). `yaml-rust` is an indirect dependency that comes from the `insta` crate, so to fix the warning we must upgrade `insta` to a version that doesn't have this problem. The `insta` crate just had a new release which fixes the problem detected by `cargo audit` (they pasted the whole `yaml-rust` crate into their tree x.x (mitsuhiko/insta#465)). We can upgrade to the latest version to get rid of the warning. Upgrading to the latest version is relatively painless, I just had to replace `assert_display_snapshot` with `assert_snapshot` because `assert_display_snapshot` is now deprecated (see https://github.com/mitsuhiko/insta/blob/8379841b8fde1cbd2fee019a9207ebea3619658f/src/macros.rs#L372) Fixes: #10876
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vendor the old
rust-yamlcrate until a replacement has been found. For discussions about alternatives see #467Replaces #461
Addresses rustsec/advisory-db#1921