Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the docker demo #20

Merged
merged 9 commits into from
Dec 7, 2023
Merged

Fixes the docker demo #20

merged 9 commits into from
Dec 7, 2023

Conversation

cnizzardini
Copy link
Member

@cnizzardini cnizzardini commented Dec 5, 2023

Ref #19

  • Add missing alpine package dependency and a few a other fixes
  • Update dockerfile to use php 8.1 (was 8.0)
  • Update composer dependencies to latest
  • Handle some deprecations related to CakePHP ErrorTrap etc.
  • Update DB seeds to work with newer version of Phinx\Seed\AbstractSeed
  • Switches to HS for JWT to pass tests for now.

Copy link

gitguardian bot commented Dec 7, 2023

⚠️ GitGuardian has uncovered 5 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
8995443 Generic High Entropy Secret 4120d58 app/tests/bootstrap.php View secret
8995443 Generic High Entropy Secret b483813 app/tests/bootstrap.php View secret
8995443 Generic High Entropy Secret b7a0d58 app/tests/bootstrap.php View secret
8995460 RSA Private Key 6640675 app/tests/private.pem View secret
8995460 RSA Private Key b7a0d58 app/tests/private.pem View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@cnizzardini cnizzardini merged commit 3ffa4b6 into main Dec 7, 2023
2 of 3 checks passed
@cnizzardini cnizzardini deleted the fix-demo branch December 7, 2023 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant