(fix) PositionScratchController: fix loop wrap-around case #14379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronso0
commented
Feb 20, 2025
Comment on lines
210
to
211
| if (loopLength < 0) { | ||
| loopLength *= -1; |
There was a problem hiding this comment.
This is not necessary, the trigger / target returned by LoopingControl::nextTrigger are already swapped in case of reverse.
ronso0
force-pushed
the
wave-scratch-wraparound-fix
branch
from
0a2f22a to
0fae9fa
Compare
ronso0
force-pushed
the
wave-scratch-wraparound-fix
branch
from
0fae9fa to
bde8400
Compare
daschuer
approved these changes
Feb 22, 2025
|
Great, thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.