-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSC T/B/L LIBLO - Experimental // WIP // Help with Findliblo.cmake needed #14388
Draft
Eve00000
wants to merge
50
commits into
mixxxdj:main
Choose a base branch
from
Eve00000:OSCLiblo
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,820
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #10999 I set WIN32_LEAN_AND_MEAN this way: |
Super, your way is the right way!, problem libshout is solved |
@Eve00000 could you please make sure you don't create more than one PR per feature? If you need to share variant of one, please use branches and reference them in description |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pr Oscpack is replaced by Liblo
I have some problems at the moment, please help.
Can someone please check my thread-handling.
can some take a look at Findliblo.cmake & CMakeLists.txt, to see why ci can't find the package or maybe something is needed in build.yml... I don't know.
By addind "add_definitions(-DWIN32_LEAN_AND_MEAN)" to CMake to help a problem with winsock and winsock2
D:\mixxx-git\mixxx\lib\libshout-idjc\src\common\timing\timing.c started to complain.
I commented Line 89-103.
Needs to be checked.
----------------> Solved thanks to @JoergAtGithub
can some take a look at CMakeLists.txt, to see if my LEAN_AND_MEAN is ok?
----------------> Solved thanks to @JoergAtGithub