Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSC T/B/L LIBLO - Experimental // WIP // Help with Findliblo.cmake needed #14388

Draft
wants to merge 50 commits into
base: main
Choose a base branch
from

Conversation

Eve00000
Copy link
Contributor

@Eve00000 Eve00000 commented Feb 21, 2025

In this pr Oscpack is replaced by Liblo

  • WIP: the entering values need to be checked (float not correct)
  • MixxxInTouchOSC works but not all functions are bidirectional.

I have some problems at the moment, please help.

  • Can someone please check my thread-handling.

  • can some take a look at Findliblo.cmake & CMakeLists.txt, to see why ci can't find the package or maybe something is needed in build.yml... I don't know.

  • By addind "add_definitions(-DWIN32_LEAN_AND_MEAN)" to CMake to help a problem with winsock and winsock2
    D:\mixxx-git\mixxx\lib\libshout-idjc\src\common\timing\timing.c started to complain.
    I commented Line 89-103.
    Needs to be checked.
    ----------------> Solved thanks to @JoergAtGithub

  • can some take a look at CMakeLists.txt, to see if my LEAN_AND_MEAN is ok?
    ----------------> Solved thanks to @JoergAtGithub

@JoergAtGithub
Copy link
Member

In #10999 I set WIN32_LEAN_AND_MEAN this way:
grafik

@Eve00000
Copy link
Contributor Author

In #10999 I set WIN32_LEAN_AND_MEAN this way: !

Super, your way is the right way!, problem libshout is solved

@Eve00000 Eve00000 changed the title OSC T/B/L LIBLO - Experimental // WIP // Please HELP OSC T/B/L LIBLO - Experimental // WIP // Check the threads please Feb 22, 2025
@acolombier
Copy link
Member

@Eve00000 could you please make sure you don't create more than one PR per feature? If you need to share variant of one, please use branches and reference them in description

@Eve00000 Eve00000 changed the title OSC T/B/L LIBLO - Experimental // WIP // Check the threads please OSC T/B/L LIBLO - Experimental // WIP // Help with Findliblo.cmake needed Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants