Improve STEM support on Windows and Mac #14392
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acolombier
force-pushed
the
chore/stem-on-win-and-macos
branch
from
e0577b5 to
4aaffd9
Compare
daschuer
reviewed
Feb 22, 2025
| @@ -116,13 +116,28 @@ bool StemInfoImporter::maybeStemFile( | |||
| mimeType = QMimeDatabase().mimeTypeForFile( | |||
| fileName, QMimeDatabase::MatchContent); | |||
| } | |||
|
|
|||
| // On Windows (at least), the MIME detection seems to sometime detect stem file | |||
| // as `video/quicktime` so we always try and detect from the extension | |||
There was a problem hiding this comment.
Interesting, have you an Idea why this happens and why it happens only on windows?
There was a problem hiding this comment.
No, no idea. This is the ffprobe of the file I used for testing
ffprobe version 7.0.2 Copyright (c) 2007-2024 the FFmpeg developers
[...]
libavutil 59. 8.100 / 59. 8.100
libavcodec 61. 3.100 / 61. 3.100
libavformat 61. 1.100 / 61. 1.100
libavdevice 61. 1.100 / 61. 1.100
libavfilter 10. 1.100 / 10. 1.100
libswscale 8. 1.100 / 8. 1.100
libswresample 5. 1.100 / 5. 1.100
libpostproc 58. 1.100 / 58. 1.100
Input #0, mov,mp4,m4a,3gp,3g2,mj2, from '/home/antoine/Music/Stems/Afroki - Save My Soul (feat. Jordan Grace).stem.mp4':
Metadata:
major_brand : isom
minor_version : 512
compatible_brands: isomiso2mp41
encoder : Lavf58.76.100
Duration: 00:03:28.04, start: 0.000000, bitrate: 1287 kb/s
Stream #0:0[0x1](und): Audio: aac (libfdk_aac) (mp4a / 0x6134706D), 44100 Hz, stereo, s16, 255 kb/s (default)
Metadata:
handler_name : SoundHandler
vendor_id : [0][0][0][0]
Stream #0:1[0x2](und): Audio: aac (libfdk_aac) (mp4a / 0x6134706D), 44100 Hz, stereo, s16, 256 kb/s
Metadata:
handler_name : SoundHandler
vendor_id : [0][0][0][0]
Stream #0:2[0x3](und): Audio: aac (libfdk_aac) (mp4a / 0x6134706D), 44100 Hz, stereo, s16, 255 kb/s
Metadata:
handler_name : SoundHandler
vendor_id : [0][0][0][0]
Stream #0:3[0x4](und): Audio: aac (libfdk_aac) (mp4a / 0x6134706D), 44100 Hz, stereo, s16, 256 kb/s
Metadata:
handler_name : SoundHandler
vendor_id : [0][0][0][0]
Stream #0:4[0x5](und): Audio: aac (libfdk_aac) (mp4a / 0x6134706D), 44100 Hz, stereo, s16, 256 kb/s
Metadata:
handler_name : SoundHandler
vendor_id : [0][0][0][0]
I have shared the file on our GDrive
There was a problem hiding this comment.
As I was testing #13470 on Windows with the stem file (and without this patch), the MIME was successfully detected so it does look like random bug.
I would suggest we keep this fix, but since I don't use Windows, I'm not too opinionated and happy to drop it if we think it was a one off
acolombier
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting for mixxxdj/vcpkg#153