Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL support using Net::Server::Proto::SSLEAY #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alladdin
Copy link

I made some changes in Starman for support SSL protocol.

  • with the changes which You suggested

miyagawa wrote:

  • Use perlstyle styles (instead of }else{ use } else {)
  • HTTP::Server::PSGI uses the following options, it would be nice to keep in sync with that: --enable-ssl --ssl-key-file=.. --ssl-cert-file=...

@alladdin
Copy link
Author

I made changes that You requested.

For enabling SSL is used $self->{ssl} parameter.

@exodist
Copy link

exodist commented Dec 27, 2011

I would find this very useful, but if I were to use it at work I would need it to get merged into the main tree and sent to cpan so that the sysadmins could install it. Can I add a vote to have this merged in?

@miyagawa
Copy link
Owner

The reason this is not merged is that simply it hasn't been tested by anyone (or at least it looks like). Bring in more people to test it and give +1 on this patch, and it will be hopefully merged.

@und3f
Copy link

und3f commented Jan 14, 2012

Patched Starman works well, but the ifs that selects between $conn->print($data) and syswrite($conn, $data) doesn't look well. Also ->print uses write() call instead of syswrite.
Possible we can bring syswrite() support to Net::Server::Proto::SSLEAY and simplify this path

@dpetrov
Copy link

dpetrov commented Mar 13, 2012

I've seen a lot of questions about starman and ssl any hints what have/must be done to merge that particular pull request?

@ap ap mentioned this pull request Apr 14, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants