Attempt at SIGTERM handling #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there, we kind of need that for one of our application. Any chance it gets merged soon? |
|
Well this is a compatibility issue, and not sure what we can do about it without breaking the users who uses the TERM signals to do what it does today. Can you step back and explain what problem you're trying to solve? |
|
Ha sorry, I didn't realize TERM was already handled for something else. Ref: https://metacpan.org/pod/distribution/Starman/script/starman Thanks for your prompt answer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that Starman doesn't handle SIGTERM signals which are sent by default from the kill executable. I've made an attempt at adding this support to Starman. I don't have an environment available to test this (we found the issue on an integration server that our Ops team manages), but took a shot at adding this support.