Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mobile api issue. #285

Merged
merged 8 commits into from
Oct 6, 2024
Merged

Fix mobile api issue. #285

merged 8 commits into from
Oct 6, 2024

Conversation

RyanL-29
Copy link
Contributor

Related issue
#281

(cherry picked from commit 50d8ea3)
(cherry picked from commit bfb1b6e)
(cherry picked from commit 8a72ece)
(cherry picked from commit c3a4bef)
(cherry picked from commit f578e75)
(cherry picked from commit 239ed1d)
(cherry picked from commit ea4173e)
(cherry picked from commit 2127107)
@RyanL-29 RyanL-29 marked this pull request as ready for review September 28, 2024 14:55
@RyanL-29
Copy link
Contributor Author

RyanL-29 commented Oct 6, 2024

@miyouzi 不好意思, 有空的話試一下這個改動是不是已經修復了 #281 , 以及我這樣修改是否恰當, 非常感謝

@miyouzi
Copy link
Owner

miyouzi commented Oct 6, 2024

還沒有測試對web解析的影響為何,確認不影響web解析的話,這邊可以先merge

@RyanL-29
Copy link
Contributor Author

RyanL-29 commented Oct 6, 2024

Web 解析那邊利用了config的use_mobile_api 進行分辨,已經測試了mobile 解析和web 解析都能用,不過為了保險起見,麻煩你也測試一下

@miyouzi
Copy link
Owner

miyouzi commented Oct 6, 2024

這會晚上才有空,我晚上測一下,感謝您的支持!

@miyouzi miyouzi changed the base branch from master to dev October 6, 2024 15:38
@miyouzi miyouzi merged commit d1e50c0 into miyouzi:dev Oct 6, 2024
2 checks passed
@miyouzi miyouzi mentioned this pull request Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants