Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will close #63 and #49
Main changes
0
. So parsing a u8 with a value of0b11
into aTransmitReceive
enum will truncate to1
, which is theTransmit
variant. Originally, this would have defaulted toReceive
, which has a value of0
.Unknown
variants fromAddress
andSubAddress
because they don't serve a purpose when parsing (the value being parsed from the message will always be 5 bits wide) and make usage confusing when the addresses are constructed by users of the library.Other changes
derive
as a default feature flagderive
for custom exampleget
toat
get_as
toget
unused_tuple_struct_fields
lint todead_code
must_use
declarations onis_
methods